| From: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Outdated comment on scram_build_secret |
| Date: | 2024-12-09 23:39:03 |
| Message-ID: | ac858943-4743-44cd-b4ad-08a0c10cbbc8@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
The documentation for the iterations parameter on scram_build_secret say:
* If iterations is 0, default number of iterations is used.
But the body of the function have the following assert
Assert(iterations > 0);
Commit b577743000 introduced the assert and remove the if condition.
All usages of this function is using an iteration > 0, so I think that
is just a matter of updating the documentation? If that's the case the
attached patch does that.
--
Matheus Alcantara
EDB: https://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-outdated-scram_build_secret-comment.patch | text/plain | 972 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2024-12-10 00:31:18 | Re: FileFallocate misbehaving on XFS |
| Previous Message | Michael Paquier | 2024-12-09 23:35:21 | Re: Memory leak in WAL sender with pgoutput (v10~) |