Re: pgsql: Move gramparse.h to src/backend/parser

Hi!

On 15.09.2022 06:52, John Naylor wrote:
> On Thu, Sep 15, 2022 at 4:04 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>>
>> The most general solution I can see would be
>>
>> diff --git i/src/backend/common.mk w/src/backend/common.mk
>> index fa96a82b1a0..61861f5c7eb 100644
>> --- i/src/backend/common.mk
>> +++ w/src/backend/common.mk
>> @@ -23,6 +23,7 @@ objfiles.txt: Makefile $(SUBDIROBJS) $(OBJS)
>>
>> ifeq ($(with_llvm), yes)
>> objfiles.txt: $(patsubst %.o,%.bc, $(OBJS))
>> +$(patsubst %.o,%.bc, $(OBJS)): $(OBJS)
>> endif
>
> Since there have been no other ideas in the past few hours, I will
> push this but it will be a blind attempt since it seems sporadic and
> doesn't happen to reproduce for me.
>

My colleague Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru> found
the similar bug on buildfarm [1] for REL_15_STABLE in the llvm build:

-D_GNU_SOURCE -I/usr/include/libxml2 -flto=thin -emit-llvm -c -o segparse.bc segparse.c
segparse.y:177:10: fatal error: 'segscan.c' file not found
177 | #include "segscan.c"
| ^~~~~~~~~~~
1 error generated

Maybe backpatch [2] to all supported versions not just 16+?

With the best regards,

--
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alligator&dt=2025-06-02%2019:07:06
[2] https://github.com/postgres/postgres/commit/16492df70bb25bc99ca3c340a75ba84ca64171b8