| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_receivewal and messages printed in non-verbose mode |
| Date: | 2017-08-16 00:29:09 |
| Message-ID: | ac58d025-ec1c-34d0-dfcd-27a86b5b873b@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7/9/17 22:08, Michael Paquier wrote:
> While the version on my laptop does that:
> if (time_to_abort)
> {
> - fprintf(stderr, _("%s: received interrupt signal, exiting\n"),
> - progname);
> + if (verbose)
> + fprintf(stderr, _("%s: received interrupt
> signal, exiting\n"),
> + progname);
> return true;
> }
> return false;
> Not sure how that feel into the cracks.
I have committed that version. I think the exit message can be useful,
because pg_receivewal will usually run as some kind of background
process where the exit status might be not be visible.
I have also committed a small documentation patch to describe the exit
status and behavior better.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-08-16 00:30:16 | Re: POC: Sharing record typmods between backends |
| Previous Message | Robert Haas | 2017-08-16 00:27:31 | Re: [COMMITTERS] pgsql: Simplify plpgsql's check for simple expressions. |