Re: pg_restore --format= option(without any value) should report an error as pg_dump is reporting an error

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_restore --format= option(without any value) should report an error as pg_dump is reporting an error
Date: 2026-03-17 16:45:41
Message-ID: abmFNYjgs1oa3asB@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 17, 2026 at 02:51:56PM +0530, Mahendra Singh Thalor wrote:
> I did some more testing and found that if there is an empty string with
> --port/--host, then we don't report any error because we don't validate
> empty strings. This looks weird to me but this is happening with all tools
> so I was not adding any test case for --host and --port.

Oh, weird.

Unless new feedback materializes, I'll proceed with committing your patch
within the next day or so.

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2026-03-17 16:50:41 table AM option passing
Previous Message Jeff Davis 2026-03-17 16:38:45 Re: Expanding HOT updates for expression and partial indexes