Re: Defend against -ffast-math in meson builds

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Defend against -ffast-math in meson builds
Date: 2026-03-11 15:51:46
Message-ID: abGPko4lPv/Bj6Bt@ip-10-97-1-34.eu-west-3.compute.internal
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Wed, Mar 11, 2026 at 11:19:45AM -0400, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> > The existing check in configure is because certain Linux distributions
> > used to compile everything with -ffast-math to be "faster", and that
> > kept breaking PostgreSQL and so we wanted to stop them very early.
> > These are gone, and the defenses in the code like date.c should be
> > sufficient for any new attempts. I think we could remove the check in
> > configure.
>
> The defenses in those modules are probably obsolete too: aren't they about
> ensuring exact results with floating-point timestamps? My gut reaction to
> this was maybe we could remove *all* of that, so now I'm curious what
> problem Bertrand ran into.

I got some regression tests failing: [1].

[1]: https://postgr.es/m/abGO%2BBl1FQlpvFAt%40ip-10-97-1-34.eu-west-3.compute.internal

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2026-03-11 15:53:23 Re: another autovacuum scheduling thread
Previous Message Andres Freund 2026-03-11 15:51:23 Re: Fix typo 586/686 in atomics/arch-x86.h