Re: Add pg_stat_recovery system view

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add pg_stat_recovery system view
Date: 2026-03-06 04:00:25
Message-ID: aapRWdyQYT6kC-k2@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 05, 2026 at 09:01:35PM +0800, Xuneng Zhou wrote:
> Here is the updated patch set. Please take a look.

Thanks. It was mostly fine, still:
- The extra mention of ROLE_PG_READ_ALL_STATS was not necessary. We
already have one at the top of the section.
- After sleeping on it, I have decided to keep recoveryLastXTime,
partially because we have a system function to retrieve it already.
- There was a refactoring piece possible when we switch a
RecoveryPauseState to a non-translatable string, which I have applied
separately.
- Added one test with pg_stat_recovery checked on a standby.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2026-03-06 04:09:41 Re: More speedups for tuple deformation
Previous Message Chao Li 2026-03-06 03:25:45 Mis-use of type BlockNumber?