Re: Add expressions to pg_restore_extended_stats()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Tender Wang <tndrwang(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(at)vondra(dot)me>
Subject: Re: Add expressions to pg_restore_extended_stats()
Date: 2026-03-04 22:29:29
Message-ID: aaiySX-NhOi8DgDw@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 04, 2026 at 05:05:55PM -0500, Corey Huinker wrote:
> 5. Generate the column list of the view (or set difference queries) with a
> \gexec query that filters out the oids.
>
> All of these things are sliiightly hacky, but if we settle on one pattern
> that will allow us to use the pattern in multiple places and thus reduce
> surprise to the reader.

I am not sure which one would be the best fit, TBH. To me, it depends
mostly on clarity and how easier it becomes to maintain these tests.
Perhaps I would have a slight preference on the views with quals based
on the object names. As long as we don't maintain the same
complicated queries more than once, I'm basically fine with any
solution. Using json for this purpose feels a bit too much artistic.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-03-04 22:34:49 Re: pgsql: Change default value of default_toast_compression to "lz4", when
Previous Message Jacob Champion 2026-03-04 22:18:16 Re: Improve OAuth discovery logging