| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, wangpeng <215722532(at)qq(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dumpall --roles-only interact with other options |
| Date: | 2026-03-03 18:50:46 |
| Message-ID: | aacthjryoKZp398P@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here's what I have staged for commit. A few notes:
* I moved the new function to option_utils.c and added a macro that takes
care of figuring out the number of arguments.
* I removed the derivative flags. I know I lobbied for those, but they
seemed out of place for this patch. Maybe we can add them separately.
* I limited the number of new tests to one per call to
check_mut_excl_opts(). I didn't see much benefit from testing everything
exhaustively.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-pg_dumpall-Fix-handling-of-conflicting-options.patch | text/plain | 10.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2026-03-03 18:55:47 | Re: pg_plan_advice (now with transparent SQL plan performance overrides - pg_stash_advice) |
| Previous Message | Tom Lane | 2026-03-03 18:47:57 | Re: Fix bug in multixact Oldest*MXactId initialization and access |