Re: [BUGS] BUG #14244: wrong suffix for pg_size_pretty()

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Greg Stark <stark(at)mit(dot)edu>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, thomas(dot)berger(at)1und1(dot)de, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #14244: wrong suffix for pg_size_pretty()
Date: 2016-07-31 05:17:17
Message-ID: aaae773d-0add-186a-a37b-70f103ab153a@commandprompt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 07/30/2016 11:16 AM, Bruce Momjian wrote:
> On Sat, Jul 30, 2016 at 10:35:58AM -0400, Tom Lane wrote:
>> Greg Stark <stark(at)mit(dot)edu> writes:

> I agree that a GUC and new functions are overkill --- we should just
> decide on the format we want to output and what to support for input.
>
> As logical as the IEC format appears, I just don't think the Ki/Mi/Gi
> prefixes are used widely enough for us to use it --- I think it will
> cause too many problem reports:
>
> https://en.wikipedia.org/wiki/Binary_prefix
>
> I have developed two possible patches for PG 10 --- the first one merely
> allows "KB" to be used in addition to the existing "kB", and documents
> this as an option.
>
> The second patch does what Tom suggests above by outputting only "KB",
> and it supports "kB" for backward compatibility. What it doesn't do is
> to allow arbitrary case, which I think would be a step backward. The
> second patch actually does match the JEDEC standard, except for allowing
> "kB".
>
> I also just applied a doc patch that increases case and spacing
> consistency in the use of kB/MB/GB/TB.
>

+1

--
Command Prompt, Inc. http://the.postgres.company/
+1-503-667-4564
PostgreSQL Centered full stack support, consulting and development.
Everyone appreciates your honesty, until you are honest with them.

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2016-07-31 22:31:46 Re: BUG #14150: Attempted to delete invisible tuple
Previous Message Peter Eisentraut 2016-07-30 20:04:12 Re: BUG #14170: error message in case LOCALE de_DE.UTF8 is used in combination with CLIENT_ENCODING=LATIN1

Browse pgsql-hackers by date

  From Date Subject
Next Message mitro palmnik 2016-07-31 07:42:08 programming libraries - collection of hash-fuctions and indexes for all situations from dbms till 3d-graphics?
Previous Message Thomas Munro 2016-07-31 01:15:55 Combining hash values