Re: pg_basebackup ignores the existing data directory permissions

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_basebackup ignores the existing data directory permissions
Date: 2019-03-20 16:02:34
Message-ID: aa3216e1-e245-0287-8d26-f5cd892b8260@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-03-19 08:34, Haribabu Kommi wrote:
> How about the following change?
>
> pg_basebackup  --> copies the contents of the src directory (with group
> access) 
> and even the root directory permissions.
>
> pg_basebackup --no-group-access   --> copies the contents of the src
> directory 
> (with no group access) even for the root directory.

I'm OK with that. Perhaps a positive option --allow-group-access would
also be useful.

Let's make sure the behavior of these options is aligned with initdb.
And write tests for each variant.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2019-03-20 16:20:11 Re: Sparse bit set data structure
Previous Message Andrey Borodin 2019-03-20 15:58:04 Re: Special role for subscriptions