Re: add assertion for palloc in signal handlers

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: add assertion for palloc in signal handlers
Date: 2026-02-18 17:37:14
Message-ID: aZX4yo30-WtmEBhD@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 18, 2026 at 09:46:43AM -0600, Nathan Bossart wrote:
> On Wed, Feb 18, 2026 at 12:13:46PM +0500, Kirill Reshke wrote:
>> Hi! I tested patch under --single (single user mode), and ISTM that we
>> can reach palloc from ProcessInterrups here?
>> Maybe we should not elog in single user mode inside sighandler...
>
> This is reproducible even without single-user mode by sending SIGQUIT to a
> client backend. Both die() and quickdie() call ereport(), and both are
> commonly used as signal handlers for SIGTERM and SIGQUIT.

I also just got an assertion failure due to something in the startup
process. Unfortunately I lost it before digging further, but I think it
was the proc_exit() call in StartupProcShutdownHandler(). I'll try to
reproduce it to get more details. In any case, I'm a bit worried that
these assertions will cause quite a bit of noise. I think we'd better
concoct a plan for dealing with them prior to inflicting the buildfarm.

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ants Aasma 2026-02-18 17:37:16 Re: pg_stat_io_histogram
Previous Message Nathan Bossart 2026-02-18 17:28:01 convert SpinLock* macros to static inline functions