| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: add warning upon successful md5 password auth |
| Date: | 2026-02-17 17:05:38 |
| Message-ID: | aZSf4sVYvSNCTcU5@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 17, 2026 at 07:08:17AM +0100, Andreas Karlsson wrote:
> After thinking more on the subject I have come around. I think warning spam
> (that can be disabled) is fine and why not introduce it directly in 19?
WFM
> As for the patch itself I think it looks good, but I am not a fan of the
> test code. Why not simply write like the below?
>
> test_conn($node, 'user=md5_role', 'md5', 0,
> log_like =>
> [qr/connection authenticated: identity="md5_role" method=md5/],
> expected_stderr =>
> [qr/authenticated with an MD5-encrypted password/])
No good reason. I've updated the patch.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Warn-upon-successful-MD5-password-authentication.patch | text/plain | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2026-02-17 17:10:46 | Re: Having problems generating a code coverage report |
| Previous Message | Corey Huinker | 2026-02-17 17:04:21 | Re: generating function default settings from pg_proc.dat |