Re: add warning upon successful md5 password auth

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: add warning upon successful md5 password auth
Date: 2026-02-17 17:11:45
Message-ID: 4ca6339b-f758-4480-b818-075e38d38c33@proxel.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/17/26 6:05 PM, Nathan Bossart wrote:
> On Tue, Feb 17, 2026 at 07:08:17AM +0100, Andreas Karlsson wrote:
>> As for the patch itself I think it looks good, but I am not a fan of the
>> test code. Why not simply write like the below?
>>
>> test_conn($node, 'user=md5_role', 'md5', 0,
>> log_like =>
>> [qr/connection authenticated: identity="md5_role" method=md5/],
>> expected_stderr =>
>> [qr/authenticated with an MD5-encrypted password/])
>
> No good reason. I've updated the patch.

Nice, the patch looks good as-is for me now.

Andreas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2026-02-17 17:16:23 Re: index prefetching
Previous Message Álvaro Herrera 2026-02-17 17:10:46 Re: Having problems generating a code coverage report