Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andreas Karlsson <andreas(at)proxel(dot)se>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier
Date: 2026-02-17 08:59:31
Message-ID: aZQt88RiILCwqCMq@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 17, 2026 at 09:20:44AM +0100, Andreas Karlsson wrote:
> Yeah, that looks like a quite nice improvement. My only comment is that if
> it was me I would have split it into two patches, one introducing the
> invalid and one replacing int. But you are much more familiar than me with
> what granularity of commits the project prefers

Splitting that into two is probably better, yes. Even if both changes
touch the same portions of perl script, it makes the introduction of
the two concepts cleaner.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2026-02-17 09:00:53 Re: Row pattern recognition
Previous Message Corey Huinker 2026-02-17 08:49:33 Re: generating function default settings from pg_proc.dat