Re: pgstat include expansion

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)kurilemu(dot)de>
Subject: Re: pgstat include expansion
Date: 2026-02-16 07:59:49
Message-ID: aZLOdXS-L_D7Nvl6@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 16, 2026 at 11:05:41AM +0530, Amit Kapila wrote:
> How about moving LogicalRepWorkerType to logicalworker.h as in the
> attached and then include that in pgstat.h? This requires few other
> adjustments as previously some of the includes were working indirectly
> via worker_internal.h.

Yep, this feels much cleaner. I am not sure we really need to limit
LogicalRepWorkerType to be in an internal header knowing that it is
exposed in the pgstat layer.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Pogrebnoi 2026-02-16 08:04:37 Re: Lowering the default wal_blocksize to 4K
Previous Message Heikki Linnakangas 2026-02-16 07:51:00 Re: Refactoring postmaster's code to cleanup after child exit