| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com> |
| Cc: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: change default default_toast_compression to lz4? |
| Date: | 2026-02-24 08:01:26 |
| Message-ID: | aZ1a1q3h1rU9kCMP@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 19, 2026 at 01:12:09PM -0300, Euler Taveira wrote:
> Changes from last version:
>
> - adjust CI
> - set not_found_dep instead of warning message
> - remove quotes from default_toast_compression value
>
> It is aligned with ICU and readline behavior.
Works for me, and I would like to apply this one.
diff --git a/meson.build b/meson.build
index 055e96315d0..13ef9c18477 100644
--- a/meson.build
+++ b/meson.build
@@ -1133,6 +1133,8 @@ if not lz4opt.disabled()
if lz4.found()
cdata.set('USE_LZ4', 1)
cdata.set('HAVE_LIBLZ4', 1)
+ else
+ lz4 = not_found_dep
endif
Hmm. Isn't this bit something that we should actually backpatch? It
feels wrong to not enforce lz4 to not_found_dep in this meson path.
So this looks unrelated to the switch of the default value.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2026-02-24 08:10:23 | Re: Wrong results with grouping sets |
| Previous Message | Alexander Lakhin | 2026-02-24 08:00:00 | Re: Refactor recovery conflict signaling a little |