Re: recovery.signal not cleaned up when both signal files are present

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Nikolay Samokhvalov <nik(at)postgres(dot)ai>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: recovery.signal not cleaned up when both signal files are present
Date: 2026-02-10 04:52:43
Message-ID: aYq5m7K3hTUtodxW@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 10, 2026 at 12:26:36PM +0900, Fujii Masao wrote:
> +1 to apply this change only to the master branch. Patch attached.

It looks like something we should have a test for, at least..

+ /*
+ *
+ * If both signal files are present, standby signal file takes precedence.
+ * If neither is present then we won't enter archive recovery.
+ */

This comment's format is incorrect.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-02-10 05:12:28 Re: Remove "struct" markers from varlena, varatt_external and varatt_indirect
Previous Message Chao Li 2026-02-10 04:50:53 Re: Enhancing Memory Context Statistics Reporting