Re: pg_upgrade: transfer pg_largeobject_metadata's files when possible

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nitin Motiani <nitinmotiani(at)google(dot)com>, Hannu Krosing <hannuk(at)google(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_upgrade: transfer pg_largeobject_metadata's files when possible
Date: 2026-02-05 17:40:50
Message-ID: aYTWIlvwo4i3UCbP@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 05, 2026 at 11:36:00AM -0600, Nathan Bossart wrote:
> @@ -1046,7 +1046,7 @@ get_object_address(ObjectType objtype, Node *object,
> address.classId = LargeObjectRelationId;
> address.objectId = oidparse(object);
> address.objectSubId = 0;
> - if (!LargeObjectExists(address.objectId))
> + if (!LargeObjectExists(address.objectId) && !IsBinaryUpgrade)
> {
> if (!missing_ok)
> ereport(ERROR,

(Probably better to set missing_ok for only the specific commands we want
to bypass this check, but you get the idea...)

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2026-02-05 17:45:56 Call for Posters: PGConf.dev 2026
Previous Message Nathan Bossart 2026-02-05 17:36:00 Re: pg_upgrade: transfer pg_largeobject_metadata's files when possible