| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Mark Wong <markwkm(at)gmail(dot)com> |
| Cc: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, David Bidoc <dcbidoc(at)gmail(dot)com>, Guillaume Lelarge <guillaume(dot)lelarge(at)dalibo(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Philip Alger <paalger0(at)gmail(dot)com> |
| Subject: | Re: oid2name : add objects file path |
| Date: | 2026-02-05 00:03:29 |
| Message-ID: | aYPeUUPRFFhNBUcp@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 04, 2026 at 12:22:40PM -0800, Mark Wong wrote:
> I took a look with Phil Alger and we just have a couple of cosmetic
> suggestions.
>
> * There is an extra period (.) added to the change in the documentation.
> * We would suggest using "Path" instead of "Filepath" in the column
> name. While "Filepath" more closely reflects the the function used,
> "Path" reads a little more smoothly, and text in existing
> documentation tends to only reads "path" instead of "file path" when
> referring to paths on the filesystem.
Yes, let's just use Path for the whole concept. The two code paths
changed apply to -x, with -t able to filter the data for a single
table. The docs have only one example when combining -x and -t,
meaning that the changes in the patch are OK.
Applied with these changes. Sorry for the delay (I had this patch
marked on my stack of TODO things).
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2026-02-05 00:15:45 | Re: Non-deterministic buffer counts reported in execution with EXPLAIN ANALYZE BUFFERS |
| Previous Message | Sami Imseih | 2026-02-04 23:48:57 | Re: Fix pg_stat_get_backend_wait_event() for aux processes |