| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Quan Zongliang <quanzongliang(at)yeah(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Consistently use the XLogRecPtrIsInvalid() macro |
| Date: | 2026-01-30 11:16:26 |
| Message-ID: | aXyTCrlkoewFa9lD@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Jan 29, 2026 at 06:45:12PM +0100, Álvaro Herrera wrote:
> On 2025-Nov-17, Bertrand Drouvot wrote:
>
> > On Mon, Nov 17, 2025 at 01:12:24PM +0000, Bertrand Drouvot wrote:
> > > The script has been updated and the patch too (finding a new replacement in
> > > gist.c).
> >
> > Finally, adding GistNSN to the game (as a typedef XLogRecPtr) gives the attached.
>
> I've pushed this.
Thanks!
I just looked at the cocci script used for that and realized (with more Coccinelle
practice) that it could be simplified. It's done in [1], and lead to a few more
cases discovered and fixed in the attached. I think that, with the attached, we
cover them all.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-other-cases-of-literal-0-instead-of-InvalidXL.patch | text/x-diff | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | David Rowley | 2026-01-30 11:10:42 | Re: More speedups for tuple deformation |