Re: refactor architecture-specific popcount code

On Thu, Jan 29, 2026 at 06:31:53PM +0700, John Naylor wrote:
> On Mon, Jan 26, 2026 at 10:41 PM Nathan Bossart
> <nathandbossart(at)gmail(dot)com> wrote:
>> I added a 0003 that swaps that final popcount with pg_popcount().
>
> I'm not sure either if this part matters much, but it makes more sense
> to me to continue using single word functions for that last part.
> Since they have very few call sites anymore, we can make them inline
> without bloating the binary on x86.

Okay, I abandoned that patch.

> Right, just the portable ones. Here, too, inlining them everywhere
> would mitigate any impact.

Done.

> +static inline int
> +pg_popcount64_neon(uint64 word)
>
> ...if they were inlined from the header, I think we wouldn't need this
> separate neon function in this file at all. Currently, we rely on
> __builtin_popcountl for the portable function outside this file. We
> could either keep using that or switch to neon if there's a
> portability difference.

Done.

--
nathan