Re: Revoke Connect Privilege from Database not working

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "Ing(dot) Marijo Kristo" <marijo(dot)kristo(at)icloud(dot)com>, PostgreSQL Bug List <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: Revoke Connect Privilege from Database not working
Date: 2026-01-21 15:28:53
Message-ID: aXDwtbXCu42Fdmrn@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-sql

On Tue, Jan 20, 2026 at 06:05:41PM -0500, Tom Lane wrote:
> Motivated by the discussion at [1], I'd started on the same idea,
> but arrived at a rather different refactorization. I think this
> way is nicer (less duplicated logic). Either way, we need to
> address the docs and probably add more regression tests.

Yeah, I think doing most of the work in select_best_grantor() is obviously
better. I recall wondering whether we should check for INHERIT or SET
privilege (or both) on the grantor role, and IIRC I settled on INHERIT
because select_best_grantor() searches through roles we have INHERIT on.

Would you like to handle docs/tests/committing, or shall I?

--
nathan

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andrei Lepikhov 2026-01-21 15:30:57 Re: BUG #19385: Normal SELECT generates an ineffecifient query plan compare to the prepared SELECT.
Previous Message Amit Langote 2026-01-21 12:58:13 Re: BUG #19099: Conditional DELETE from partitioned table with non-updatable partition raises internal error

Browse pgsql-sql by date

  From Date Subject
Next Message Tom Lane 2026-01-21 16:57:01 Re: Revoke Connect Privilege from Database not working
Previous Message Tom Lane 2026-01-20 23:05:41 Re: Revoke Connect Privilege from Database not working