Re: Resetting recovery target parameters in pg_createsubscriber

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
Cc: 'Alena Vinter' <dlaaren8(at)gmail(dot)com>, Andrey Rudometov <unlimitedhikari(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ilyasov Ian <ianilyasov(at)outlook(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Resetting recovery target parameters in pg_createsubscriber
Date: 2026-01-16 03:15:09
Message-ID: aWmtPfc0XktJM9om@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 16, 2026 at 08:25:34AM +0900, Michael Paquier wrote:
> On Thu, Jan 15, 2026 at 07:05:20AM +0000, Hayato Kuroda (Fujitsu) wrote:
> > Thanks for working on the project. I found that one of BF animal fairywren has
> > been failing [1] the pg_createsubscriber test since the commit 639352d904c.
> > Can you help solving the issue?
>
> Thanks for the poke. I'll look into it in details.

pg_ctl's 001_start_stop.pl, or even ssl_passphrase_callback's
001_testfunc.pl seem to be in line with what you are suggesting
Kuroda-san. Both tests include an "external" pg_ctl start command and
explicitely stop the node to prevent an issue like the one we are
seeing here. Hence, your suggestion of fix should be enough. I have
added a comment to explain why a direct pg_ctl command is used, and
applied the result.

Let's now see if fairywren gets back to green. I'll keep an eye on
the buildfarm.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-01-16 03:19:01 Re: fix a spelling mistake
Previous Message Chao Li 2026-01-16 02:51:50 Re: pg_upgrade: optimize replication slot caught-up check