| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Tender Wang <tndrwang(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Extended Statistics set/restore/clear functions. |
| Date: | 2026-01-15 23:22:48 |
| Message-ID: | aWl2yJpzcQeKkgQ1@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 15, 2026 at 03:21:23PM -0500, Corey Huinker wrote:
> That may have been done because some of the code that will end up here is
> being moved from other files rather than being purely new. My revised patch
> is leaving it as-is for now.
This can be a tricky one. Portions of this new code rely on code that
is much older than it, so this choice is just to be on the safe side
(aka I've chosen that).
> In addition to issues 1 and 4 I added some inheritance-specific tests per
> Paquier's off-list request, and the result is attached.
Thanks. I have tweaked that a bit more, switching to GROUP BY clauses
based on the inherited field, and also added a check for the lock
level we take on the relation, by bundling a call within a
transaction. Then applied the result.
I have a bunch of other changes for the rest of the patch set, that
needs to be refreshed based on the choices we had to deal with for the
clear function. I'll send that in a couple of hours, before moving on
with more reviews next week..
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-01-15 23:25:34 | Re: Resetting recovery target parameters in pg_createsubscriber |
| Previous Message | Tom Lane | 2026-01-15 23:19:41 | Re: Buffer locking is special (hints, checksums, AIO writes) |