| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | zengman <zengman(at)halodbtech(dot)com> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Fix minor issues in astreamer_zstd.c |
| Date: | 2026-01-11 07:32:06 |
| Message-ID: | aWNR9iDqQThcqONC@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 11, 2026 at 04:10:36PM +0900, Michael Paquier wrote:
> Could you demonstrate one or more examples when using these APIs
> proving that in some cases the current code can be a problem while the
> "fixed" code improves the situation, then extract test cases to be
> able to cover our future tracks? This would take the shape of one or
> more regression tests to demonstrate individual problems. If the
> three code paths touched here prove to be problematic, we would need
> three cases in total. One other possibility would be to use a set of
> asserts to make sure that nobody uses these APIs in ways we don't
> expect them to.
See for example 3369a3b49b0b as one reference, that has fixed a bug in
the same area of the code.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuya Kawata | 2026-01-11 07:34:43 | Re: [Patch]Add tab completion for DELETE ... USING |
| Previous Message | Michael Paquier | 2026-01-11 07:10:36 | Re: [PATCH] Fix minor issues in astreamer_zstd.c |