| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Richard Guo <guofenglinux(at)gmail(dot)com> |
| Subject: | Re: JumbleQuery ma treat different GROUP BY expr as the same |
| Date: | 2026-01-11 10:12:46 |
| Message-ID: | aWN3nkHOSu392MFX@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 10, 2026 at 11:46:27AM -0500, Tom Lane wrote:
> It is not what happened before we invented RTE_GROUP. I tried your
> experiment in v14 and got:
>
> regression=# SELECT calls, rows, query FROM pg_stat_statements ORDER BY query COLLATE "C";
> calls | rows | query
> -------+------+---------------------------------------------------------------
> 1 | 1 | SELECT pg_stat_statements_reset() IS NOT NULL AS t
> 1 | 0 | explain(costs off, verbose) select count(*) from t group by a
> 1 | 0 | explain(costs off, verbose) select count(*) from t group by b
> 1 | 0 | explain(costs off, verbose) select count(*) from t group by c
> (4 rows)
>
> So I'm inclined to think this was an unintentional change of behavior.
The difference of behavior is between v17 and v18, as an effect of
247dea89f761. I know that we should not break query ID computations
in stable branches, but v18 is very recent and we still have many
years to support it.. So I would like to suggest that we make an
exception and backpatch a fix to v18. This behavior is not cool for
users.
This issue also points to a gap in the regression of
pg_stat_statements, where we have never bothered testing patterns of
GROUP BY with the same table and different attributes. Jian, would
you like to write a patch?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | zengman | 2026-01-11 10:20:34 | Re: [PATCH] Fix minor issues in astreamer_zstd.c |
| Previous Message | Huanbing Lu | 2026-01-11 09:51:54 | Re: SQL Property Graph Queries (SQL/PGQ) |