Re: pgsql: Add data type oid8, 64-bit unsigned identifier

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add data type oid8, 64-bit unsigned identifier
Date: 2026-01-07 03:12:38
Message-ID: aV3PJvIpF8fmhfIL@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Jan 06, 2026 at 10:03:01PM -0500, Tom Lane wrote:
> sifaka doesn't like this, evidently because it uses
> -DSTRESS_SORT_INT_MIN.

Yes, I have noticed that. I was just going to push a workaround that
uses '>' and '<' comparators instead of the direct outputs..

> Personally I'd just drop those tests of btoid8cmp --- what are they
> going to catch that's not caught by other tests?

btoid8cmp() is not tested directly by other tests, which is why, like
for the xid8 case, I have just added direct calls because that's
cheaper.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2026-01-07 03:58:47 pgsql: Improve portability of test with oid8 comparison function
Previous Message Tom Lane 2026-01-07 03:03:01 Re: pgsql: Add data type oid8, 64-bit unsigned identifier