Re: Switch buffile.c/h to use pgoff_t

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bryan Green <dbryan(dot)green(at)gmail(dot)com>
Subject: Re: Switch buffile.c/h to use pgoff_t
Date: 2025-12-24 06:15:22
Message-ID: aUuE-hAC1qPAnH75@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 23, 2025 at 10:59:45AM +0800, Chao Li wrote:
> I’ve attached a small patch along these lines. It compiles without
> warnings, and "make check" passes on my side. What do you think?

I don't think it is right. bytestowrite is not a file offset, and the
code has been using an int due to BufFile->nbytes. This leads to a
more confusing result.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-12-24 06:21:04 Re: correct a word
Previous Message Michael Paquier 2025-12-24 05:55:58 Re: Startup PANIC on standby promotion due to zero-filled WAL segment