Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Burd, Greg" <greg(at)burd(dot)me>, Nikita Malakhov <hukutoc(at)gmail(dot)com>, Hannu Krosing <hannuk(at)google(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)
Date: 2025-12-18 05:40:24
Message-ID: aUOTyLSp8sT4uiOj@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 11, 2025 at 07:47:05AM +0900, Michael Paquier wrote:
> On Mon, Dec 08, 2025 at 04:19:54PM -0500, Robert Haas wrote:
> > I took a brief look at this today, looking at parts of v8-0005 and
> > v8-0015.
>
> Thanks for the input!

The CF bot was complaining that this patch set needed a rebase due to
the recent changes in pg_resetwal, so here we go. For now this is the
same stuff as the previous versions, with the same separation and
design.

I am also looking at what it would take to implement what the brutal
approach I have mentioned upthread. This requires a bit more
reorganization than what I had in mind initially. By putting first in
the patch set some of the parts that are kind of relevant with the two
designs, things seem to be a bit leaner. I need to spend a few more
hours on that beforebeing sure, though..

For now, rebase for a happy bot.
--
Michael

Attachment Content-Type Size
v9-0001-Implement-oid8-data-type.patch text/x-diff 38.7 KB
v9-0002-Refactor-some-TOAST-value-ID-code-to-use-Oid8-ins.patch text/x-diff 15.4 KB
v9-0003-Minimize-footprint-of-TOAST_MAX_CHUNK_SIZE-in-hea.patch text/x-diff 4.6 KB
v9-0004-Renames-around-varatt_external-varatt_external_oi.patch text/x-diff 20.3 KB
v9-0005-Refactor-external-TOAST-pointer-code-for-better-p.patch text/x-diff 46.3 KB
v9-0006-Move-static-inline-routines-of-varatt_external_oi.patch text/x-diff 4.7 KB
v9-0007-Split-VARATT_EXTERNAL_GET_POINTER-for-indirect-an.patch text/x-diff 5.9 KB
v9-0008-Switch-pg_column_toast_chunk_id-return-value-from.patch text/x-diff 3.6 KB
v9-0009-Add-catcache-support-for-OID8OID.patch text/x-diff 1.3 KB
v9-0010-Add-support-for-TOAST-chunk_id-type-in-binary-upg.patch text/x-diff 9.3 KB
v9-0011-Enlarge-OID-generation-to-8-bytes.patch text/x-diff 14.5 KB
v9-0012-Add-relation-option-toast_value_type.patch text/x-diff 6.5 KB
v9-0013-Add-support-for-oid8-TOAST-values.patch text/x-diff 16.9 KB
v9-0014-Add-tests-for-TOAST-relations-with-bigint-as-valu.patch text/x-diff 21.5 KB
v9-0015-Add-new-vartag_external-for-8-byte-TOAST-values.patch text/x-diff 14.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2025-12-18 06:00:30 Re: Skipping schema changes in publication
Previous Message Chao Li 2025-12-18 05:31:24 Re: Proposal: Cascade REPLICA IDENTITY changes to leaf partitions