Re: [Proposal] Adding callback support for custom statistics kinds

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [Proposal] Adding callback support for custom statistics kinds
Date: 2025-12-17 22:42:00
Message-ID: aUMxuMX788So0i6E@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 17, 2025 at 11:01:01AM -0600, Sami Imseih wrote:
> I got the attached patch ready with some additional comments in
> the callback definitions to clarify the API contract. We only need
> to call out the "header' nuance since it's a const in one callback
> and not the other. "key" is self documenting being a const in both
> cases.

The comment sounds like a good idea, so included it and applied the
result. Thanks for looking!
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zsolt Parragi 2025-12-17 23:52:57 Re: Custom oauth validator options
Previous Message GRANT ZHOU 2025-12-17 21:43:31 Re: Improve logical replication usability when tables lack primary keys