Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB ?barriers

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Greg Burd <greg(at)burd(dot)me>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Dave Cramer <davecramer(at)gmail(dot)com>
Subject: Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB ?barriers
Date: 2025-12-16 18:07:34
Message-ID: aUGf5oyzguybiUBB@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 16, 2025 at 08:23:19AM -0500, Greg Burd wrote:
> On Mon, Dec 15, 2025, at 6:08 PM, Andres Freund wrote:
>> LGTM
>
> LGTM, thanks everyone.

Here's what I have staged for commit. I searched around for anything else
that might be missing, and I only found a couple of small things. First,
there are some optional AArch64 optimizations (simd.h and popcount) that
likely need more work, but those can wait for now. Also, while the patch
is targeting Windows 11 (IIUC), there are some notes in the docs that give
the impression Windows 10 is supported, too [0]. I could easily change it
to say that AArch64 requires Windows 11, but I don't know what to do with
the references to specific versions of Visual Studio and the Windows SDK.
Thoughts? Maybe that can wait, too.

[0] https://www.postgresql.org/docs/devel/installation-platform-notes.html#INSTALLATION-NOTES-VISUAL-STUDIO

--
nathan

Attachment Content-Type Size
v12-0001-Add-support-for-Windows-on-AArch64.patch text/plain 5.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2025-12-16 18:43:31 Re: [BUG] [PATCH] pg_basebackup produces wrong incremental files after relation truncation in segmented tables
Previous Message Christoph Berg 2025-12-16 17:54:46 Re: failed NUMA pages inquiry status: Operation not permitted