Re: Fix memory leak in gist_page_items() of pageinspect

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix memory leak in gist_page_items() of pageinspect
Date: 2025-12-15 13:39:56
Message-ID: aUAPrAH2SQtk9PBz@ip-10-97-1-34.eu-west-3.compute.internal
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Mon, Dec 15, 2025 at 06:56:06PM +0800, Chao Li wrote:
> On Mon, Dec 15, 2025 at 5:28 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> >
> > I think your point is valid. Let's not break the current meaning of
> > maxlen. I added buf_initialized in v3. As 0001 has been pushed, v2-0002 now
> > becomes v3-0001.
> >
> > Oops, forgot the attachment. Here comes it.

LGTM, thanks!

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Rahila Syed 2025-12-15 13:48:09 Re: Add WALRCV_CONNECTING state to walreceiver
Previous Message Euler Taveira 2025-12-15 13:38:08 Re: Add support for specifying tables in pg_createsubscriber.