Re: Switch buffile.c/h to use pgoff_t

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bryan Green <dbryan(dot)green(at)gmail(dot)com>
Subject: Re: Switch buffile.c/h to use pgoff_t
Date: 2025-12-25 23:45:00
Message-ID: aU3MfBO_4umfxgE6@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 25, 2025 at 10:40:02AM +0800, Chao Li wrote:
> In attached v3, I have applied int64 to the 2 struct fields and
> corresponding local variables. I ran a clean build, no warning was
> introduced, and "make check" passed.

The advantage of being able to make the code transparently more
pluggable for max large sizes while we already use 8-byte offsets is
kind of nice, I guess. "availbytes" is a clarification bonus as it is
not an offset per-se. I can see that you have missed on cast spot, so
adjusted things a bit, then applied the result.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Xuneng Zhou 2025-12-26 00:31:26 Re: Implement waiting for wal lsn replay: reloaded
Previous Message Michael Paquier 2025-12-25 23:01:41 Re: [PATCH] Optionally record Plan IDs to track plan changes for a query