| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [Proposal] Adding callback support for custom statistics kinds |
| Date: | 2025-12-13 02:00:30 |
| Message-ID: | aTzIvl7_aXnBzH-t@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 12, 2025 at 06:41:20PM -0600, Sami Imseih wrote:
> I made some changes as well, in v8:
>
> 1/ looks like b4cbc106a6ce snuck into v7. I fixed that.
Oops, sorry about that. I went one reset too deep.. I can see that
my local branch was also wrong, an a rebase fixed it immediately.
> 2/ After looking this over, I realized that “extra” and “auxiliary”
> were being used interchangeably. To avoid confusion, I replaced all
> instances of “extra” with “auxiliary" in both the comments and
> macros, i.e. TEST_CUSTOM_AUX_DATA_DESC
I can see what you have changed in v8 compared to v7, in terms of the
elog(), the comments and TEST_CUSTOM_AUX_DATA_DESC. That works for
me. If somebody has a better idea for a name, these can always be
tweaked at will.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-12-13 02:37:40 | Re: Fix memory leak in gist_page_items() of pageinspect |
| Previous Message | Sami Imseih | 2025-12-13 00:41:20 | Re: [Proposal] Adding callback support for custom statistics kinds |