Re: Proposal: Add a callback data parameter to GetNamedDSMSegment

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Proposal: Add a callback data parameter to GetNamedDSMSegment
Date: 2025-12-11 22:39:58
Message-ID: aTtIPvpRGCf-fWoM@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks for the new patch.

On Thu, Dec 11, 2025 at 04:12:02PM -0600, Sami Imseih wrote:
> I went back-forth on if it makes sense to provide the name as an
> extra argument and decided it provides more flexibility. For example
> I can use the same init callback and arguments for different segments.

If the initialization callback function needed the name, it could be
provided via the "void *" callback argument, right? I'm not following why
we need to provide it separately.

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-12-11 22:49:03 Re: Improve pg_sync_replication_slots() to wait for primary to advance
Previous Message Chao Li 2025-12-11 22:36:50 Re: Fix uninitialized PruneFreezeResult in pruneheap and vacuumlazy