Re: Add wait event for CommitDelay

On Fri, Dec 05, 2025 at 10:15:19AM -0600, Sami Imseih wrote:
> I am not sure how widely used this GUC is, but from the quick test that I
> did using pgench TPC-B workload with 50 clients, it seems useful
> since a DBA can set commit_delay too high and you will easily observe
> a single backend constantly in this delay which will impact tps.
> It's good to show this clearly as a wait event.

I have never used it myself, but I can see why it could be useful for
monitoring here. No objections to this addition here.

> As far as the patch goes, It makes sense to put this under "WaitEventTimeout",
> but it should be placed after CHECKPOINT_WRITE_DELAY in
> alphabetical order, and the description could be improved a bit.
> How about? "Waiting for the commit delay before WAL flush."

Yes, your description is more useful than what the patch is proposing.
--
Michael