Re: Use func(void) for functions with no parameters

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Use func(void) for functions with no parameters
Date: 2025-12-03 16:10:10
Message-ID: aTBg4go8hGybzrXr@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 03, 2025 at 03:53:37PM +0000, Bertrand Drouvot wrote:
> The buildfarm animal remark makes me think to check with -Wstrict-prototypes
> and -Wold-style-definition. I just did that and found two more (added in v2
> attached) that the coccinelle script missed...
>
> Those new two (run_apply_worker() and usage()) are also static, so that's just
> chance.

LGTM, too. I'll take care of committing this shortly.

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ignat Remizov 2025-12-03 16:44:51 Re: [PATCH] Add enable_copy_program GUC to control COPY PROGRAM
Previous Message Andres Freund 2025-12-03 16:03:40 Re: Buffer locking is special (hints, checksums, AIO writes)