| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Remove useless pointer advance in StatsShmemInit() |
| Date: | 2025-12-03 15:55:40 |
| Message-ID: | aTBdfKkJE//QGkp4@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Wed, Dec 03, 2025 at 10:13:55AM -0500, Andres Freund wrote:
> On 2025-12-03 08:14:41 +0000, Bertrand Drouvot wrote:
> > So, what about documenting them all?
>
> I'm -0.1 on that. I think it's just as likely that those code comments will
> not be moved when another chunk of memory is needed and cause confusion that
> way. Sorry, but to me this is just a case of restating obvious code in an
> obvious mechanical comment.
No problem at all, thanks for sharing your thoughts!
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2025-12-03 15:56:32 | Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY |
| Previous Message | Bertrand Drouvot | 2025-12-03 15:53:37 | Re: Use func(void) for functions with no parameters |