| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Remove unused function parameters, part 2: replication |
| Date: | 2025-11-28 09:24:23 |
| Message-ID: | aSlqR9muXkt1YyOf@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
PFA a patch to remove unused function parameters in replication (means
focusing on src/backend/replication).
Those have been detected by a coccinelle script (that I need to polish before
sharing). It currently only focuses on static functions.
While reviewing the coccinelle script output, I did a bit of Archeology to know
where the oversights come from (which helps with review), and that gives:
off_t *offset in HandleUploadManifestPacket(): dc212340058b
PGOutputData *data in check_and_init_gencol(): 7054186c4ebe
ReorderBuffer *rb in ReorderBufferRestoreCleanup(): b89e151054a0
ReorderBuffer *rb in ReorderBufferMaybeMarkTXNStreamed(): 072ee847ad4c
ReplicationSlot *slot in ReorderBufferSerializedPath(): 8aa75e1384b1
ReorderBuffer *rb in ReorderBufferFreeSnap(): b89e151054a0
TransactionId xid in ReorderBufferReplay(): a271a1b50e9b
Oid relid in ApplyLogicalMappingFile(): b89e151054a0
RetainDeadTuplesData *rdt_data in can_advance_nonremovable_xid(): 228c37086855
RetainDeadTuplesData *rdt_data in resume_conflict_info_retention(): 0d48d393d465
StringInfo s in apply_handle_origin(): 665d1fad99e7
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Removing-unused-function-parameters-in-replicatio.patch | text/x-diff | 16.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2025-11-28 09:29:10 | Re: How can end users know the cause of LR slot sync delays? |
| Previous Message | Rahila Syed | 2025-11-28 09:22:14 | Re: Enhancing Memory Context Statistics Reporting |