Re: Refactoring: Use soft error reporting for *_opt_overflow functions of date/timestamp

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Amul Sul <sulamul(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Refactoring: Use soft error reporting for *_opt_overflow functions of date/timestamp
Date: 2025-11-28 00:46:07
Message-ID: aSjwz7scT0J-2FxY@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 27, 2025 at 06:18:32PM +0900, Amit Langote wrote:
> On Thu, Nov 27, 2025 at 4:58 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>> One question: Regarding date2timestamp_no_overflow(), should we rename
>> it to date2double? We can't use date2timestamp_safe because we already
>> have that function. The renaming is relevant because this function
>> converts a date to the double data type, which allows us to remove the
>> "_no_overflow" extension.
>
> Makes sense to me.

Yes, it would be nice to change all this area at once to remain
consistent across the board. date2timestamp_no_overflow() is the last
"no_overflow" routine in date.h.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2025-11-28 01:34:14 Simplify code building the LR conflict messages
Previous Message Peter Smith 2025-11-28 00:35:59 Re: Proposal: Conflict log history table for Logical Replication