| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | 邱宇航 <iamqyh(at)gmail(dot)com> |
| Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Xuneng Zhou <xunengzhou(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Aidar Imamov <a(dot)imamov(at)postgrespro(dot)ru>, Joseph Koshakow <koshy44(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add pg_buffercache_mark_dirty[_all] functions to the pg_buffercache |
| Date: | 2025-11-27 04:17:11 |
| Message-ID: | aSfQx0GafuMwCRWD@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 27, 2025 at 11:07:43AM +0800, 邱宇航 wrote:
> Yes, and we got another two loops in pg_buffercache_evict functions,
> and more loops in Drop/Flush relation/database buffers functions. Maybe
> we can abstract them into a generic loop function and it takes a buffer
> handler function pointer to avoid duplication?
I was considering an option when looking at the patch this morning,
but could not get behind it as it hides the internals of the routines
inside one extra layer of routines.. So what Nazir has done seems
like a balance good enough, at least for me.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-11-27 04:29:56 | Move WAL/RMGR sequence code into its own file and header |
| Previous Message | Tom Lane | 2025-11-27 04:04:43 | Re: Partial hash index is not used for implied qual. |