Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)

On Tue, Sep 30, 2025 at 03:26:14PM +0900, Michael Paquier wrote:
> There were a few conflicts, so here is a rebased v7, moving the patch
> to the next CF. I have been sitting on this patch for six weeks for
> the moment.

Attached is a rebased v8, fixing a couple of conflicts.

> Tom, you are registered as a reviewer of the patch. The point of
> contention of the patch, where I see there is no consensus yet, is if
> my approach of using a redirection for the external TOAST pointers
> with a new layer to facilitate the addition of more vartags (aka the
> 64b value vartag proposed here, concept that could also apply to
> compression methods later on) is acceptable. Moving to a different
> approach, like the "brutal" one I am naming upthread where the
> redirection layer is replaced by changes in all the code paths that
> need to be touched, would be of course cheaper at runtime as there
> would be no more redirection, but the maintenance would be a nightmare
> the more vartags we add, and I have some plans for more of these.
> Doing the switch would be a few hours work, so that would not be a big
> deal, I guess. The important part is an agreement about the approach,
> IMO.

This point still got no reply. It would be nice to do something for
this release regarding this old issue, IMO..
--
Michael