Re: Extended Statistics set/restore/clear functions.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us
Subject: Re: Extended Statistics set/restore/clear functions.
Date: 2025-11-26 02:06:10
Message-ID: aSZgkssl7NT1jI2h@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 25, 2025 at 04:28:51PM +0900, Michael Paquier wrote:
> With that said, a v18 for the first two patches with the input
> functions. Comments and/or opinions?

Okay. I have gone other these two and after an extra round of
polishing, mainly around comments (some suggested by Chao, actually),
style, a fix for the test with valid UTF8 sequences failing in
non-UTF8 databases, plus a few more tests that were missing, I have
applied the two patches for the input functions.

Perhaps these will need some adjustments, but I also see little point
in moving on with these based on the coverage we have and how the code
is shaped. Could you rebase the rest of the patch set for the three
remaining pieces, Corey? You will also need to address some of the
comments from Chao based on a review of v16, that were not addressed
as of v17.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Euler Taveira 2025-11-26 02:11:46 Re: log_min_messages per backend type
Previous Message Chao Li 2025-11-26 01:50:54 Re: Remaining dependency on setlocale()