Re: Changing the state of data checksums in a running cluster

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tomas Vondra <tomas(at)vondra(dot)me>
Cc: Andreas Karlsson <andreas(at)proxel(dot)se>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Bernd Helmle <mailings(at)oopsware(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Changing the state of data checksums in a running cluster
Date: 2025-11-21 19:57:35
Message-ID: aSDEL0gEX90gpQ34@momjian.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 21, 2025 at 01:17:09PM +0100, Tomas Vondra wrote:
> True. Hence the stress testing I've been doing - and indeed, that made
> us discover the various issues reported in this thread.
>
> Still, isn't that similar to error paths in various other patches? Those
> also tend to be rarely exercised in practice. I think the right way to
> address that is more testing. Of course, there's a difference between
> "regular bugs" and "design problems". Some of the issues are more about
> the design/architecture not considering something important.
>
> I don't know if / when this will be ready for commit. Maybe never, who
> knows. I prefer going step by step. We know about a couple issues, we
> need to figure out what to do about those. Then we can reconsider.
>
> FWIW I'm not sure the number of people currently enabling checksums on
> production databases is a good metric of how important the patch is.
> Maybe more people would like to do that, but can't accept the downtime.

I think it is a worth-while feature. We would have had it years ago
except that people asked for re-start-ability after a crash, and since
we don't have restart logic at the relation level, the patch got too
complex and was abandoned.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nico Williams 2025-11-21 19:57:38 Re: RFC 9266: Channel Bindings for TLS 1.3 support
Previous Message Greg Burd 2025-11-21 19:52:03 Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB ​barriers