| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Quan Zongliang <quanzongliang(at)yeah(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Consistently use the XLogRecPtrIsInvalid() macro |
| Date: | 2025-12-02 14:35:48 |
| Message-ID: | aS75RIAQhAiWBHH0@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, Dec 02, 2025 at 08:44:28AM +0100, Peter Eisentraut wrote:
> On 01.12.25 08:14, Bertrand Drouvot wrote:
> > Hi,
> >
> > On Tue, Nov 18, 2025 at 04:54:32PM +0100, Peter Eisentraut wrote:
> > > I mean, some people like writing if (!foo) and some like writing if
> > > (foo == NULL), but we're not going to legislate one
> > > over the other.
> >
> > Agree. Out of curiosity, I searched for pointers and literal zero comparisons
> > or assignments (with [1]) and found 6 of them.
> >
> > While literal zero is technically correct, NULL is the semantically appropriate
> > choice for pointers.
> >
> > PFA a patch to fix those 6.
>
> committed (required pgindent)
Thanks!
Doh, I always run pgindent unless when I think the changes could not break the
indentation.
Note to self: always run pgindent, no thinking required ;-)
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2025-12-02 14:39:07 | Re: Remove useless casting to the same type |
| Previous Message | Bertrand Drouvot | 2025-12-02 14:28:48 | Re: Remove unused function parameters, part 2: replication |