| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Move WAL/RMGR sequence code into its own file and header |
| Date: | 2025-12-01 07:24:08 |
| Message-ID: | aS1CmM9FozFvTFL2@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 28, 2025 at 01:05:55PM +0900, Michael Paquier wrote:
> On Thu, Nov 27, 2025 at 12:00:30PM +0300, Kirill Reshke wrote:
>> Shouldnt `SEQ_LOG_VALS` be moved to sequnce_xlog.c ?
>
> I am not sure to follow this one. This controls the frequency of the
> records inserted, which has nothing to do with the redo path.
>
>> Also, while on it, maybe it is worth to rename xl_seq_rec struct to
>> something. It will be more convenient to make a name in sync with the
>> XLOG_SEQ_LOG WAL record (like we do in heapxlog). Maybe struct
>> xl_seq_log ?
>
> I am not sure to see the value in a rename for the scope of this
> patch, sequence.h already published them.
On a second look, I cannot get behind these two arguments. So I have
applied the patch as-is, after fixing a comment. Now onto some more
interesting work..
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-12-01 07:55:50 | missing PG_IO_ALIGN_SIZE uses |
| Previous Message | cca5507 | 2025-12-01 07:20:16 | Re: [Patch] Build the heap more efficient in tuplesort.c |