Re: Remove unused function parameters, part 2: replication

Hi,

On Fri, Nov 28, 2025 at 01:39:19PM -0500, Andres Freund wrote:
> I am pretty unconvinced this kind of stuff is worth the noise they produce in
> the more general case too.

I agree that it's noisy and time consuming to review, that's the drawback of using
automated tools when they find and produce a noticeable number of changes.

I'd say the tool is there [1], we know we can use it if we feel the need and the
energy to review.

We can still continue to fix them when we cross them "accidentally".

That said, it somehow sounds weird to wait to cross them accidentally knowing we
have the tool to find them, so I'm still not convinced that just ignoring them
is the right thing to do.

[1]: https://github.com/bdrouvot/coccinelle_on_pg/blob/main/misc/unused_function_parameters.cocci

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com