| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots |
| Date: | 2025-11-14 15:46:30 |
| Message-ID: | aRdO1k-G65U50w0L@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, Nov 14, 2025 at 09:55:37AM -0500, Andres Freund wrote:
> Hi,
>
> On 2025-11-14 09:49:02 -0500, Bruce Momjian wrote:
> > On Fri, Nov 14, 2025 at 09:25:20AM -0500, Andres Freund wrote:
> > > Hi,
> > >
> > > On 2025-11-14 09:12:33 -0500, Bruce Momjian wrote:
> > > > On Fri, Nov 14, 2025 at 09:05:07AM -0500, Andres Freund wrote:
> > > > > Hi,
> > > > >
> > > > > On 2025-11-14 09:02:12 -0500, Andres Freund wrote:
> > > > > > On 2025-11-14 13:56:06 +0000, Bruce Momjian wrote:
> > > > > > > doc: remove verbiage about "receiving" data from rep. slots
> > > > > > >
> > > > > > > The slots are just LSN markers, not something to receive from.
> > > > > >
> > > > > > I think this is wrong. Logical slots also preserve resources other than WAL.
> > > > >
> > > > > I also think that the complaint about slots not being something to receive
> > > > > from is simply wrong for logical slots.
> > > >
> > > > Uh, can you clarify since I can't find details on what they preserve.
> > >
> > > Slots (physical ones can, logical ones always do), prevent row cleanup on the
> > > primary.
> >
> > I see your point. How is the attached patch? The link right after the
> > modified text talks only about WAL retention, so I think we need
> > something in this sentence to say we do more than WAL retention for
> > logical replication slots.
>
> It's less wrong, but I don't think this is the right place to add more
> documentation about what replication slots do.
Patch applied. I can keep improving it as we get more ideas.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2025-11-14 17:14:15 | Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots |
| Previous Message | Bruce Momjian | 2025-11-14 15:46:22 | pgsql: doc: clarify that logical slots track transaction activity |