Re: Uncommented GUC in postgresql.conf.sample

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Uncommented GUC in postgresql.conf.sample
Date: 2025-11-14 14:51:03
Message-ID: aRdB10QRdvMXa4IQ@momjian.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 14, 2025 at 09:44:42AM -0500, Tom Lane wrote:
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> > When looking at the nearby suggestion to add deprecation comment for md5 in the
> > .conf.sample, I happened to notice that autovacuum_worker_slots isn't commented
> > out it the sample file.
>
> > AFAIK all GUCs in the sample file should be set to their defaults and left
> > commented out.
>
> Yes, that is surely a bug. It should be fixed and back-patched.

Yes, but again, be aware that only new initdb's will see this change.
People doing a diff against an old postgresql.conf file and a new
initdb's postgresql.conf.sample in the same major release might see this
change and think they did it.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-11-14 14:57:46 Re: Uncommented GUC in postgresql.conf.sample
Previous Message Tom Lane 2025-11-14 14:44:42 Re: Uncommented GUC in postgresql.conf.sample