Re: obsolete autovacuum comment

On Wed, Nov 12, 2025 at 06:09:40PM +0100, Álvaro Herrera wrote:
> The comment you cite appears more or less in the same place in
> autovacuum-6.patch (the routine was called test_rel_for_autovac there),
> but I think what it really is about, is the AVOperUpdateCounts operation
> that was in autovacuum-5.patch. Note that that older patch was
> introducing a new pg_autovacuum catalog which kept track of tuple counts
> since last analyze/vacuum, and those counts needed to be updated in case
> pgstats was reset. But by patch autovacuum-6.patch this had disappeared
> (the counts were now in pgstats, per review from Tom), so we didn't need
> to reset any counters, and the AVOperUpdateCounts operation went away.
>
> It's quite possible that, having removed the "counter reset" operation
> from the proposed patch and reduced the comment to what we have today,
> we promptly forgot about the whole thing. So the comment is indeed a
> relic that can be removed.

I see, thanks for looking. I've committed the patch.

--
nathan